Skip to content

GPU: Implement TPC timebin cut during ZS decoding.#14837

Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom
fweig:tpc-adc-cut
Dec 1, 2025
Merged

GPU: Implement TPC timebin cut during ZS decoding.#14837
davidrohr merged 1 commit intoAliceO2Group:devfrom
fweig:tpc-adc-cut

Conversation

@fweig
Copy link
Contributor

@fweig fweig commented Nov 20, 2025

No description provided.

@fweig fweig requested a review from davidrohr as a code owner November 20, 2025 14:50
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

davidrohr
davidrohr reviewed Nov 20, 2025
View reviewed changes
davidrohr
davidrohr approved these changes Nov 22, 2025
View reviewed changes
Copy link
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without checking in detail, looks good.
Did you test that it works correctly in all ZS modes?
Or do I need to run some checks before merging?

@alibuild
Copy link
Collaborator

alibuild commented Nov 22, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for d017bac at 2025-11-24 16:20:

[3187/4997] Linking CXX executable stage/bin/o2-mch-statusmap-to-rejectlist
[3188/4997] Building CXX object Detectors/MUON/MID/Simulation/CMakeFiles/O2lib-MIDSimulation.dir/G__O2MIDSimulation.cxx.o
[3189/4997] Linking CXX executable stage/tests/o2-test-mch-statusmap
[3190/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/DecodedDataAggregatorSpec.cxx.o
[3191/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/FilteringBCSpec.cxx.o
[3192/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/RawInputSpecHandler.cxx.o
[3193/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/MaskHandlerSpec.cxx.o
[3194/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/DigitReaderSpec.cxx.o
[3195/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/TimingSpec.cxx.o
[3196/4997] Building CXX object Detectors/MUON/MCH/DigitFiltering/CMakeFiles/O2lib-MCHDigitFiltering.dir/src/DigitModifier.cxx.o
[3197/4997] Building CXX object Detectors/MUON/MCH/DigitFiltering/CMakeFiles/O2lib-MCHDigitFiltering.dir/src/DigitFilterParam.cxx.o
[3198/4997] Building CXX object Detectors/MUON/MCH/DigitFiltering/CMakeFiles/O2lib-MCHDigitFiltering.dir/src/DigitModifierParam.cxx.o
[3199/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/FilteringSpec.cxx.o
[3200/4997] Building CXX object Detectors/FIT/FV0/workflow/CMakeFiles/O2lib-FV0Workflow.dir/src/EntropyEncoderSpec.cxx.o
[3201/4997] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2lib-EMCALCalibration.dir/G__O2EMCALCalibration.cxx.o
[3202/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/MaskMakerSpec.cxx.o
[3203/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/CalibDataProcessorSpec.cxx.o
[3204/4997] Building CXX object Detectors/MUON/MCH/DigitFiltering/CMakeFiles/O2lib-MCHDigitFiltering.dir/G__O2MCHDigitFiltering.cxx.o
[3205/4997] Building CXX object Detectors/MUON/MCH/DigitFiltering/CMakeFiles/O2lib-MCHDigitFiltering.dir/src/DigitFilter.cxx.o
[3206/4997] Building CXX object Detectors/MUON/MID/Simulation/test/CMakeFiles/O2test-mid-Simulation.dir/testSimulation.cxx.o
[3207/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/RawCheckerSpec.cxx.o
[3208/4997] Linking CXX shared library stage/lib64/libO2EMCALCalibration.so
[3209/4997] Linking CXX shared library stage/lib64/libO2FV0Workflow.so
[3210/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/RawDecoderSpec.cxx.o
[3211/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/RawGBTDecoderSpec.cxx.o
[3212/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/RawWriterSpec.cxx.o
[3213/4997] Linking CXX executable stage/bin/o2-calibration-emcal-pedestal-processor-workflow
[3214/4997] Building CXX object Detectors/CTF/CMakeFiles/O2test-ctf-fv0.dir/test/test_ctf_io_fv0.cxx.o
[3215/4997] Linking CXX executable stage/bin/o2-calibration-emcal-pedestal-calib-workflow
[3216/4997] Linking CXX executable stage/bin/o2-emcal-run-calib-offline
[3217/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/RawDumpSpec.cxx.o
[3218/4997] Linking CXX executable stage/tests/o2-test-emcal-PedestalProcessorData
[3219/4997] Linking CXX executable stage/bin/o2-fv0-reco-workflow
[3220/4997] Linking CXX executable stage/bin/o2-fv0-entropy-encoder-workflow
[3221/4997] Linking CXX executable stage/bin/o2-fv0-digit-reader-workflow
[3222/4997] Linking CXX executable stage/tests/o2-test-ctf-fv0
[3223/4997] Linking CXX executable stage/bin/o2-fv0-digits-writer-workflow
[3224/4997] Linking CXX executable stage/bin/o2-fv0-recpoints-reader-workflow
[3225/4997] Linking CXX executable stage/bin/o2-fv0-flp-dpl-workflow
[3226/4997] Linking CXX executable stage/bin/o2-fv0-recpoints-writer-workflow
[3227/4997] Linking CXX executable stage/bin/o2-fv0-integrate-cluster-workflow
[3228/4997] Linking CXX executable stage/bin/o2-fv0-integrate-cluster-reader-workflow
[3229/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/ZeroSuppressionSpec.cxx.o
[3230/4997] Linking CXX executable stage/bin/o2-fv0-merge-integrate-cluster-workflow
[3231/4997] Linking CXX shared library stage/lib64/libO2MIDSimulation.so
[3232/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/TrackReaderSpec.cxx.o
[3233/4997] Building CXX object Detectors/MUON/MID/Workflow/CMakeFiles/O2lib-MIDWorkflow.dir/src/TrackerSpec.cxx.o
[3234/4997] Linking CXX executable stage/tests/o2-test-mid-Geometry
[3235/4997] Building CXX object Detectors/MUON/MCH/DigitFiltering/CMakeFiles/O2exe-mch-digits-filtering-workflow.dir/src/digits-filtering-workflow.cxx.o
[3236/4997] Linking CXX executable stage/tests/o2-test-mid-Simulation

Full log here.

@fweig
Copy link
Contributor Author

fweig commented Nov 24, 2025

Without checking in detail, looks good. Did you test that it works correctly in all ZS modes? Or do I need to run some checks before merging?

I checked GPU and CPU version of the dense link decoder so far for different cut off values. I can also setup tests for the other ZS modes today.

@davidrohr
Copy link
Collaborator

davidrohr commented Nov 24, 2025

that would be great, thanks!

@fweig
Copy link
Contributor Author

fweig commented Dec 1, 2025

Tested the timebin cut for the remaining ZS versions on CPU and GPU with different cut values. Implementation works and gives the same result across all versions.

@davidrohr
Copy link
Collaborator

davidrohr commented Dec 1, 2025

Great, thx!

@davidrohr davidrohr merged commit 22e2e61 into AliceO2Group:dev Dec 1, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr davidrohr approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fweig @alibuild @davidrohr